Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Ensure SimpleSchemaIngress uses FastAPI custom serializers #24549

Merged
merged 1 commit into from
May 6, 2022
Merged

[Serve] Ensure SimpleSchemaIngress uses FastAPI custom serializers #24549

merged 1 commit into from
May 6, 2022

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented May 6, 2022

Why are these changes needed?

Previous PRs only enabled it for FastAPI in bring your own app. This PR enables it for DAGDriver and ModelWrapper. I also tested @krfricke's repro script ensure it working.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo simon-mo mentioned this pull request May 6, 2022
Merged
6 tasks
@edoakes edoakes added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 6, 2022
@simon-mo simon-mo merged commit 95c11c9 into ray-project:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees

@edoakes edoakes

@krfricke krfricke

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon-mo @edoakes @krfricke